Comments on: Simple Jquery and CSS menu

By: Web Design Glasgow

Web Design Glasgow — Sat, 18 Apr 2009 13:54:10 +0000

Hi,
My main concern with JQuery is its forward compatiblilty. I do know it has MIT license aswell as a GNU license. However there are no guarantees today and how many actual users out there actually switch JavaScript off; most have not even heard about it let alone know what it is. I think you have to look at the target audience when evaluating any product.

regards
George

By: Vrbo

Vrbo — Wed, 25 Feb 2009 18:13:50 +0000

Jquery is defiantly a great addition to my scripting. Btw, I have used toggle() more times then i could remember so easy to take advantage of all the options it has.

Welcome aboard!

By: G. Barr

G. Barr — Sat, 31 Jan 2009 16:34:10 +0000

Hi,

Looking at the blog, I’ll need to checkout JQuery.

thanks
George

By: redsquare

redsquare — Sun, 13 Jul 2008 19:08:06 +0000

No probs, any issues come join us at #jquery irc channel on freenode

By: admin

admin — Sun, 13 Jul 2008 18:11:29 +0000

Hi Redsquare,

Thanks for your comment! For some reason I never think to use the ternary operator – good tip. I’ll also check out the toggle() function. Still got quite a bit of reading to do to be completely up to speed on Jquery, but I’m loving the experience so far!

Cheers,
John

By: redsquare

redsquare — Sun, 13 Jul 2008 15:19:48 +0000

Hi Mate,
Welcome to jq. I noticed in your code that you repeated the selector.

The following snippet
if($(”li:not(:first)”).is(”:visible”)){
$(”li:not(:first)”).fadeOut(”fast”);
}else{
$(”li:not(:first)”).fadeIn(”fast”);
}
would read better as

var listItems = $(”li:not(:first)”);
listItems.is(”:visible”) ? listItems.fadeOut(”fast”) : listItems.fadeIn(”fast”);

small improvement but good for performance and readability

However even better would be to make use of the toggle() function

so you can say

$(”li.starter”).toggle(
function(){
$(”li:not(:first)”).fadeIn(”fast”);
},
function(){
$(”li:not(:first)”).fadeOut(”fast”);
}
);

Now each click will toggle between the two given functions.

Happy jqueing